JIANG/EPANET
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

fixes regression related to tank fill/empty events

Browse Source 
In the affected code, q is really just a proxy for flow direction. And in cases where a tank has filled in a previous step, its connected link will have been TEMPCLOSED making the flow pretty small. When this occurs, the link actually never opens even if dH says that the tank should be draining.
This commit is contained in:
Sam Hatchett
2024-06-24 13:08:13 -04:00
parent 109a93f7d5
commit 0329819f04
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/hydstatus.c
View File

@@ -433,10 +433,10 @@ void tankstatus(Project *pr, int k, int n, double q)
if (tank->A == 0.0) return; if (tank->A == 0.0) return;
// Can't add flow to a full tank // Can't add flow to a full tank
if (hyd->NodeHead[n] >= tank->Hmax && !tank->CanOverflow && q < TINY) if (hyd->NodeHead[n] >= tank->Hmax && !tank->CanOverflow && q < 0.0)
hyd->LinkStatus[k] = TEMPCLOSED; hyd->LinkStatus[k] = TEMPCLOSED;
// Can't remove flow from an empty tank // Can't remove flow from an empty tank
else if (hyd->NodeHead[n] <= tank->Hmin && q > -TINY) else if (hyd->NodeHead[n] <= tank->Hmin && q > 0.0)
hyd->LinkStatus[k] = TEMPCLOSED; hyd->LinkStatus[k] = TEMPCLOSED;
} }