Elad Salomons
dc7e9f3142
Merge pull request #672 from lbutler/dev-gpv-control-fix
...
Fix for GPV controls in EN_saveinpfile
Thank you @lbutler , for GPV the setting golds the head curve index.
2022-04-05 07:27:54 +03:00
Luke Butler
9c0b576182
Fix for GPV controls in EN_saveinpfile
...
EN_saveinpfile was incorrectly saving the index of the GPV head loss curve inside of a simple control instead of the control status
2022-03-30 23:13:48 -04:00
Luke Butler
0945683bf9
Bug in example code for detecting error conditions
...
EN_geterror doesn't take in the project wrapper, and you need to include maxLen
2022-03-30 11:14:05 -04:00
Lew Rossman
4bdbe6cd78
Modify const. HP pump
2022-03-30 09:22:01 -04:00
Lew Rossman
2beb5fb5b9
Merge pull request #667 from OpenWaterAnalytics/dev-fix-tanktimestep
...
Fixes possible integer overflow
2022-03-30 09:12:15 -04:00
Lew Rossman
cecc941d29
Update to force re-check of PR
2022-03-20 09:27:37 -04:00
Lew Rossman
dbd3f6387d
Fixes possible integer overflow
...
Fixes a possible integer overflow when computing time for a tank to fill/empty (issue #666 ). Also fixes issue #642 that failed to set a pump's initial setting to 0 when its initial status was CLOSED.
2022-03-19 13:25:55 -04:00
Lew Rossman
c8a3eadfdf
Merge pull request #634 from OpenWaterAnalytics/dev-PDA_mod
...
Dev pda mod
2022-03-19 08:53:15 -04:00
Lew Rossman
750dda1fe6
Update ReleaseNotes2_3.md
2022-02-14 15:38:21 -05:00
Lew Rossman
0687aa63e2
Update ReleaseNotes2_3.md
2022-02-14 15:10:18 -05:00
Lew Rossman
f865cbbba8
Update ReleaseNotes2_3.md
2022-02-14 13:43:48 -05:00
Lew Rossman
a63f553b5f
Adds PDA convergence test
2022-02-14 11:19:00 -05:00
Lew Rossman
070901d6bf
Update hydsolver.c
2022-02-14 11:03:22 -05:00
Lew Rossman
d5c9a95c5f
Merge pull request #660 from OpenWaterAnalytics/dev-DefaultPatternFix
...
Fix for getting/setting/saving default demand pattern option
2022-01-18 11:01:10 -05:00
Lew Rossman
43092c8647
Update test_node.cpp
2022-01-15 11:37:35 -05:00
Lew Rossman
f9189d04b4
Updates to default demand pattern fix
2022-01-15 11:21:24 -05:00
Lew Rossman
14de37d0cb
Adjust default pattern index after a pattern is deleted
2022-01-14 09:09:32 -05:00
Lew Rossman
afda609223
Adds get/set for default demand pattern to toolkit
2022-01-14 08:50:33 -05:00
Elad Salomons
64f0d15afe
Merge pull request #657 from OpenWaterAnalytics/dev-Qualflag_Fix
...
Removes silent change to WQ option for 0 duration run
2021-09-28 10:09:26 +03:00
Elad Salomons
4b2d686c5d
Merge pull request #649 from jamesuber/dev
...
Bugfix for En_getaveragepatternvalue() and Return MISSING initial setting from EN_getlinkvalue()
2021-09-27 10:50:46 +03:00
Lew Rossman
d552d0c92c
Removes silent change to WQ option for 0 duration run
2021-09-25 09:32:20 -04:00
james uber
3be813facb
Return MISSING as initial valve setting
...
If the initial setting is indeed MISSING, that means the status of the valve has been set to OPEN or CLOSED, and the valve is non-functional (until the setting is changed by a control). This change is required to be able to accurately see the initial setting, because the status does not distinguish between open and active valves.
2021-09-23 11:04:19 -04:00
james uber
886a5cf266
Bugfix for En_getaveragepatternvalue()
...
Fixes a bug where 0 was not considered to be a valid pattern index.
2021-09-08 10:49:57 -04:00
Elad Salomons
7baf992d69
Merge pull request #646 from Mariosmsk/returnErrcodeNodeNotTank
...
Thank you @Mariosmsk
2021-08-02 06:16:22 +03:00
Elad Salomons
7a07976104
Merge pull request #648 from sahandt/patch-1
...
Method parameter types need to match definitions in epanet2.c
2021-08-01 20:34:10 +03:00
Sahand Tashak
1df2ea80b0
Method parameter types need to match definitions in epanet2.c
2021-07-20 22:58:43 -04:00
mariosmsk
79b2c4c8ee
add new errcode 263 "node is not a tank"
2021-06-26 17:11:33 +03:00
mariosmsk
6728a59e63
node is not a tank
2021-06-26 12:01:19 +03:00
Elad Salomons
45c62f6656
Merge pull request #641 from eladsal/zero-rcoeff
...
Fix check for roughness coefficient
2021-06-18 12:39:26 +03:00
Elad Salomons
b1255dead8
Fix check for roughness coefficient
...
Fix check for roughness coefficient
2021-06-15 16:15:54 +03:00
Lew Rossman
650d8e8e53
Revert "Update setup.py"
...
This reverts commit b77094e694
2021-04-21 00:24:27 -04:00
Lew Rossman
b77094e694
Update setup.py
2021-04-21 00:09:36 -04:00
Lew Rossman
c64cbe1b5f
Restoring previous versions of nrtest files that work
2021-04-20 15:59:23 -04:00
Lew Rossman
a652175523
Update test-config.sh
...
Another attempt to eliminate the Status Report comparison.
2021-04-20 15:24:09 -04:00
Lew Rossman
5c0a6efb30
Update setup.py
...
Trying to eliminate the Status Report comparison.
2021-04-20 15:04:18 -04:00
Lew Rossman
ac86db1340
Adjustment to regression test criteria - 3
2021-04-20 10:25:43 -04:00
Lew Rossman
9e286293ae
Adjustment to regression test criteria - 2
2021-04-20 10:13:03 -04:00
Lew Rossman
e58d36c6a1
Revert "Update hydcoeffs.c"
...
This reverts commit 13416942f8
2021-04-20 09:36:01 -04:00
Lew Rossman
13416942f8
Update hydcoeffs.c
2021-04-20 09:30:11 -04:00
Lew Rossman
9224d67a00
Adjustment to regression test criteria
2021-04-20 09:26:34 -04:00
Lew Rossman
bec7c0db0f
Remove line comments with release number
2021-04-17 10:24:42 -04:00
Lew Rossman
175544f3be
Merge pull request #624 from OpenWaterAnalytics/dev_tank_fix
...
Empty tank draining fix
2021-04-16 17:23:07 -04:00
Lew Rossman
409a600455
Improved flow checks for full and empty tanks
...
Improves the way link flow into full and out of empty tanks is checked. Also corrects the head loss and gradient calculation for constant horsepower pumps at very low and very high flow rates (this was affecting one of the examples used to test the full/empty tank fix).
2021-04-16 17:01:54 -04:00
Elad Salomons
506f0ecb9d
Merge pull request #630 from eladsal/comments_bas
...
Add comments APIs to VB bas include file
2021-03-08 13:49:34 +02:00
Elad Salomons
427fb03fe5
Add comments APIs to VB bas include file
2021-02-24 17:51:29 +02:00
Lew Rossman
aaa9b44aaf
Removed unreferenced variable in hydstatus.c
2021-01-26 15:47:04 -05:00
Lew Rossman
9d2256433f
Fix having flow out of an empty tank
2021-01-26 15:41:01 -05:00
Lew Rossman
1e0c65e04e
Merge pull request #619 from OpenWaterAnalytics/fix_energy_usage
...
Update hydraul.c
2020-12-18 11:11:46 -05:00
Lew Rossman
854abdf5d2
Update hydraul.c
...
Fixes a bug that was adding time on-line to a closed pump's energy usage for the time step just prior to when a rule-based control re-opens it.
2020-12-09 20:26:13 -05:00
Lew Rossman
533466b796
PDA changes to improve convergence
2020-11-19 16:23:24 -05:00
