Commit Graph

307 Commits

Author SHA1 Message Date
mariosmsk
e0745e9dc5 Update epanet.c 2020-06-25 20:22:12 +03:00
mariosmsk
532f89d14b Net1.inp have 0 MinorLoss / GUI accepts values zero for MINORLOSS. Similar to the parameter Power of pumps 2020-06-25 20:11:27 +03:00
james uber
949022ed49 API access to incontrols() for information about node/link controls participation
allowing access to incontrols() for getting information about whether a node or link participates in a simple or rule-based control.
2020-05-22 11:45:52 -04:00
Elad Salomons
37342c70b1 Another option for EN_settankdata fix 2020-04-19 18:05:08 +03:00
Lew Rossman
37a58a467c Update epanet.c 2020-04-19 09:25:36 -04:00
Lew Rossman
99f09f1edb A simpler fix to EN_settankdata
Changes 1 line instead of 4.
2020-04-19 09:16:08 -04:00
Elad Salomons
3f515e7ad4 Fix EN_settankdata for elevation with SI units
Fix #593
2020-04-19 09:42:43 +03:00
Corey McNeish
ee5e910454 Alloc, free persistent parts of Hydraul in allocdata, rather than in allocmatrix 2020-04-11 11:33:37 -07:00
chrisgs
364ad08bcc Limit EN_STARTTIME parameter value to SECperDAY
Limit `EN_STARTTIME` parameter value to a maximum of `SECperDAY`, and
return an error code if this is exceeded.
2020-03-23 22:14:02 +00:00
chrisgs
21e1e4c019 Allow start time to be set with EN_settimeparam
Add additional case for `EN_STARTTIME` to the `EN_settimeparam`
function.
2020-03-21 17:13:40 +00:00
mariosmsk
25f9a6f6d1 fix EN_INITSETTING
Co-Authored-By: Lew Rossman <lrossman@outlook.com>
Co-Authored-By: Elad Salomons <selad@optiwater.com>

#583
2020-02-09 22:05:40 +02:00
Lew Rossman
80f9acfe4d Network building enhancements 2020-02-04 10:01:23 -05:00
Lew Rossman
ce2a27f38e Bug fix for valvecheck function
See issue #561
2019-11-15 11:53:09 -05:00
Lew Rossman
6c54bb3a59 Adds error check to EN_setheadcurveindex
See issue #556 .
2019-11-09 09:36:10 -05:00
Lew Rossman
9998466d20 Bug fix for EN_getrule
Fixes possible seg fault condition in EN_getrule. Also defines EN_MISSING as an API constant since it can be assigned internally to several variables that are retrievable by the API.
2019-11-05 10:09:21 -05:00
Lew Rossman
3bd4039d95 Bug fix for EN_setcurve
Adjusts params of any pump that uses the curve whose data is modified by EN_setcurve or EN_setcurvevalue (issue #550 ).
2019-11-02 11:17:25 -04:00
Lew Rossman
1709b12f6a Fixes to EN_addlink and EN_deletelink 2019-10-29 20:09:56 -04:00
Lew Rossman
7aadc83ddf Adds link vertex get/set functions to the API 2019-10-29 16:33:40 -04:00
Lew Rossman
b640a8685c Adds EN_getresultindex function to the API
See issue #546 . Also fixes a small bug in project.c.
2019-10-26 11:25:09 -04:00
Lew Rossman
344700a136 Fixes problems with EN_addnode() (#543)
See issue #542 . Also modifies unit test test_node to check that fixup works.
2019-10-16 15:07:14 -04:00
mariosmsk
eb04559a11 rm set to null in functions EN_deletenode, EN_deletelink 2019-08-10 11:51:21 +03:00
mariosmsk
1ce6901103 fix in EN_deleteLink
when pipes are deleted via deletelink it also deletes comment of last link

Co-Authored-By: Pavlos Pavlou <pavlou.v.pavlos@ucy.ac.cy>
2019-08-08 15:50:19 +03:00
Lew Rossman
803bad0bf0 Fixes EN_setlinkvalue bug 2019-08-05 14:08:18 -04:00
mariosmsk
4e2e6c952a Fix EN_getElseaction and EN_setelseaction
Co-Authored-By: Andreas Ashikkis <andreasashikkis@users.noreply.github.com>
2019-07-24 16:13:37 +03:00
Lew Rossman
a89f339525 PDA fixes 2019-07-22 09:50:41 -04:00
Sam Hatchett
3fe11b98ee rethinking the python wrapper (#511)
* renames certain function parameter declarations and removes double pointer call from the deleteproject function

* deprecates conditonal compilation, removes python-specific headers and function renaming

* fixes tests and docs

* fixes test
2019-07-17 15:19:25 -04:00
Lew Rossman
9669742ab3 Adds tank overflow feature 2019-06-17 09:16:04 -04:00
Lew Rossman
6a5aa372f8 Change default properties for new pipe created with EN_addlink (issue #500) 2019-05-28 11:17:44 -04:00
Lew Rossman
c9b836973e Removes _DEBUG directives from all source files
This commit removes the #ifdef _DEBUG statements at the top of all source code files per issue #482. It also updates the doc files to stress that the speedup observed for hydraulic analysis with the MMD node re-ordering method only applies to single period runs.
2019-05-13 23:49:19 -04:00
Lew Rossman
365ab00dcb Refactors the API's demand editing functions 2019-05-09 10:26:40 -04:00
Elad Salomons
eefc7f7d05 For "conditional" do delete a node connected to a link
For "conditional" deletion the node is deleted only if all of its links have been explicitly deleted beforehand #473

Co-Authored-By: Lew Rossman <lrossman@outlook.com>
2019-05-06 11:36:41 +03:00
Lew Rossman
97be7944f4 Fix problems with setting tank parameters (issue #464 ) 2019-04-25 08:22:44 -04:00
Michael Tryby
35cf9bd422 Fix bug and test remove demand 2019-04-24 18:40:47 -04:00
Michael Tryby
dc3c2ffe1a Adding remove demand method to toolkit 2019-04-24 16:30:27 -04:00
Michael Tryby
cf97cf8c9c Work in progress
code cleanup, addressed issue raised in review, and implemented EN_adddemand()
2019-04-23 17:52:11 -04:00
Michael Tryby
feee7f2c80 Update epanet.c
Updating EN_getnodevalue() and EN_setnodevalue() to process the primary demand located at the head of the demand list
2019-04-23 14:42:37 -04:00
michaeltryby
f19d43d3a4 Merge branch 'dev' of https://github.com/OpenWaterAnalytics/EPANET into dev-list 2019-04-22 13:36:44 -04:00
michaeltryby
d34ac67172 updating get demand name and write demands
Everything passing locally
2019-04-22 12:14:33 -04:00
michaeltryby
97f70e445d Update epanet.c
Trying to isolate bug
2019-04-22 11:07:01 -04:00
Michael Tryby
7537be1ec9 Work in progress
Working on demand lists
2019-04-19 18:01:06 -04:00
Michael Tryby
76b6254f33 get/set demand name are passing 2019-04-18 17:07:50 -04:00
Michael Tryby
bf519fdd94 Work in progress
Fixing problems when demand lists are null
2019-04-18 14:24:30 -04:00
Lew Rossman
1583bea154 Return object index from EN_addnode and EN_addlink (issue #432)
Adds an output argument to EN_addnode and EN_addlink that returns the index of the newly added object.
Also refactors the validity check on object ID names.
2019-04-18 07:00:07 -04:00
Michael Tryby
109276e379 Work in progress
Implementing generic demand pattern lists. Compiles but does not run.
2019-04-17 17:24:34 -04:00
Michael Tryby
d1979e7ed0 Update errror code from 250 to 252 2019-04-17 09:39:24 -04:00
Michael Tryby
3186ec326c Adding element id validity check
Adding checks for element set id functions
2019-04-16 17:29:32 -04:00
Michael Tryby
22a7993c8c Adding element id validity checks 2019-04-16 16:57:38 -04:00
Michael Tryby
9c4665a661 Fixes memory leak in EN_addnode() (#455)
* Fixing memory leak in EN_addnode()

* Separating test_net_builder from test_toolkit

Making test_net_builder a standalone test

* Removing BOOST_TEST_MAIN

* Work in progress
2019-04-11 18:04:20 -04:00
Michael Tryby
cf1fc43a4d Merge branch 'dev' of https://github.com/OpenWaterAnalytics/EPANET into Mariosmsk-fix_bug_getdemandname 2019-04-08 15:22:16 -04:00
Michael Tryby
14af368876 Merge branch 'fix_bug_getdemandname' of https://github.com/Mariosmsk/EPANET into Mariosmsk-fix_bug_getdemandname 2019-04-08 14:44:05 -04:00