fix(results): support legacy render refs

2026-05-21 18:18:16 +08:00
parent 7427d08d6c
commit ab12d79d91
4 changed files with 342 additions and 8 deletions
@@ -1,5 +1,5 @@
 import { afterEach, beforeEach, describe, expect, it } from "bun:test";
-import { mkdtemp, rm, writeFile } from "node:fs/promises";
+import { mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { join } from "node:path";

@@ -177,6 +177,13 @@ describe("ResultReferenceResolver", () => {
      filePath,
      JSON.stringify(
        {
+          metadata: {
+            createdAt: "2026-05-21T00:00:00.000Z",
+            projectId: "project-3",
+          },
+          location: {
+            file_path: filePath,
+          },
          data: {
            node_area_map: {
              J1: "DMA-1",
@@ -232,4 +239,179 @@ describe("ResultReferenceResolver", () => {
      },
    });
  });
+
+  it("repairs wrapper files that omit metadata and location", async () => {
+    const filePath = join(tempDir, "render-wrapper-missing-fields.json");
+    await writeFile(
+      filePath,
+      JSON.stringify(
+        {
+          data: {
+            node_area_map: {
+              J1: "DMA-1",
+            },
+          },
+          createdAt: "2026-05-21T00:00:00.000Z",
+        },
+        null,
+        2,
+      ),
+      "utf8",
+    );
+
+    const record = await resolver.registerRenderPayloadFile(filePath, {
+      actorKey: "actor-4",
+      clientSessionId: "client-4",
+      projectId: "project-4",
+      projectKey: "project-key-4",
+      sessionId: "session-4",
+      source: RESULT_REFERENCE_SOURCE.migration,
+      traceId: "trace-4",
+    });
+
+    expect(record.kind).toBe(RESULT_REFERENCE_KIND.renderJunctionsPayload);
+
+    const repaired = JSON.parse(await readFile(filePath, "utf8")) as {
+      metadata?: Record<string, unknown>;
+      location?: Record<string, unknown>;
+    };
+
+    expect(repaired.metadata).toEqual({
+      createdAt: "2026-05-21T00:00:00.000Z",
+      projectId: "project-4",
+    });
+    expect(repaired.location).toEqual({
+      file_path: filePath,
+    });
+  });
+
+  it("repairs wrapper files whose location points elsewhere", async () => {
+    const filePath = join(tempDir, "render-wrapper-wrong-location.json");
+    await writeFile(
+      filePath,
+      JSON.stringify(
+        {
+          metadata: {
+            createdAt: "2026-05-21T00:00:00.000Z",
+          },
+          location: {
+            file_path: "/tmp/elsewhere.json",
+            source: "legacy",
+          },
+          data: {
+            node_area_map: {
+              J1: "DMA-1",
+            },
+          },
+        },
+        null,
+        2,
+      ),
+      "utf8",
+    );
+
+    await resolver.registerRenderPayloadFile(filePath, {
+        actorKey: "actor-4",
+        clientSessionId: "client-4",
+        projectId: "project-4",
+        projectKey: "project-key-4",
+        sessionId: "session-4",
+        source: RESULT_REFERENCE_SOURCE.migration,
+        traceId: "trace-4",
+      });
+
+    const repaired = JSON.parse(await readFile(filePath, "utf8")) as {
+      metadata?: Record<string, unknown>;
+      location?: Record<string, unknown>;
+    };
+
+    expect(repaired.metadata).toEqual({
+      createdAt: "2026-05-21T00:00:00.000Z",
+      projectId: "project-4",
+    });
+    expect(repaired.location).toEqual({
+      file_path: filePath,
+      source: "legacy",
+    });
+  });
+
+  it("resolves legacy render payload files when callers include the json suffix", async () => {
+    const legacyRef = "res-c2fcee33-577e";
+    await writeFile(
+      join(tempDir, `${legacyRef}.json`),
+      JSON.stringify(
+        {
+          data: {
+            node_area_map: {
+              J1: "DMA-1",
+              J2: 2,
+            },
+            area_ids: ["DMA-1"],
+          },
+          createdAt: "2026-05-21T00:00:00.000Z",
+          projectId: "project-legacy-render",
+        },
+        null,
+        2,
+      ),
+      "utf8",
+    );
+
+    const result = await resolver.getFullAuthorized(
+      `${legacyRef}.json`,
+      {
+        actorKey: "actor-legacy-render",
+        clientSessionId: "chat-legacy-render",
+        projectId: "project-legacy-render",
+      },
+      {
+        expectedKind: RESULT_REFERENCE_KIND.renderJunctionsPayload,
+      },
+    );
+
+    expect(result?.result_ref).toBe(legacyRef);
+    expect(result?.kind).toBe(RESULT_REFERENCE_KIND.renderJunctionsPayload);
+    expect(result?.source).toBe(RESULT_REFERENCE_SOURCE.legacy);
+    expect(result?.data).toEqual({
+      node_area_map: {
+        J1: "DMA-1",
+        J2: "2",
+      },
+      area_ids: ["DMA-1"],
+    });
+  });
+
+  it("keeps legacy render payload files scoped to their project", async () => {
+    const legacyRef = "res-dddddddddddddddd";
+    await writeFile(
+      join(tempDir, `${legacyRef}.json`),
+      JSON.stringify(
+        {
+          data: {
+            node_area_map: {
+              J1: "DMA-1",
+            },
+          },
+          projectId: "project-allowed",
+        },
+        null,
+        2,
+      ),
+      "utf8",
+    );
+
+    const result = await resolver.getFullAuthorized(
+      legacyRef,
+      {
+        actorKey: "actor-legacy-render",
+        clientSessionId: "chat-legacy-render",
+        projectId: "project-denied",
+      },
+      {
+        expectedKind: RESULT_REFERENCE_KIND.renderJunctionsPayload,
+      },
+    );
+
+    expect(result).toBeNull();
+  });
 });