Clean code
This commit is contained in:
@@ -76,7 +76,7 @@ class Tank(object):
|
||||
return { 'type': self.type, 'id': self.id }
|
||||
|
||||
|
||||
def set_tank_cmd(name: str, cs: ChangeSet) -> DbChangeSet:
|
||||
def _set_tank(name: str, cs: ChangeSet) -> DbChangeSet:
|
||||
old = Tank(get_tank(name, cs.operations[0]['id']))
|
||||
raw_new = get_tank(name, cs.operations[0]['id'])
|
||||
|
||||
@@ -104,10 +104,10 @@ def set_tank(name: str, cs: ChangeSet) -> ChangeSet:
|
||||
return ChangeSet()
|
||||
if get_tank(name, cs.operations[0]['id']) == {}:
|
||||
return ChangeSet()
|
||||
return execute_command(name, set_tank_cmd(name, cs))
|
||||
return execute_command(name, _set_tank(name, cs))
|
||||
|
||||
|
||||
def add_tank_cmd(name: str, cs: ChangeSet) -> DbChangeSet:
|
||||
def _add_tank(name: str, cs: ChangeSet) -> DbChangeSet:
|
||||
new = Tank(cs.operations[0])
|
||||
|
||||
redo_sql = f"insert into _node (id, type) values ({new.f_id}, {new.f_type});"
|
||||
@@ -129,10 +129,10 @@ def add_tank(name: str, cs: ChangeSet) -> ChangeSet:
|
||||
return ChangeSet()
|
||||
if get_tank(name, cs.operations[0]['id']) != {}:
|
||||
return ChangeSet()
|
||||
return execute_command(name, add_tank_cmd(name, cs))
|
||||
return execute_command(name, _add_tank(name, cs))
|
||||
|
||||
|
||||
def delete_tank_cmd(name: str, cs: ChangeSet) -> DbChangeSet:
|
||||
def _delete_tank(name: str, cs: ChangeSet) -> DbChangeSet:
|
||||
old = Tank(get_tank(name, cs.operations[0]['id']))
|
||||
|
||||
redo_sql = sql_delete_coord(old.id)
|
||||
@@ -154,7 +154,7 @@ def delete_tank(name: str, cs: ChangeSet) -> ChangeSet:
|
||||
return ChangeSet()
|
||||
if get_tank(name, cs.operations[0]['id']) == {}:
|
||||
return ChangeSet()
|
||||
return execute_command(name, delete_tank_cmd(name, cs))
|
||||
return execute_command(name, _delete_tank(name, cs))
|
||||
|
||||
|
||||
#--------------------------------------------------------------
|
||||
|
||||
Reference in New Issue
Block a user