feat(map): manage agent overlays in layer panel

src/features/workbench/hooks/use-workbench-map.ts

@@ -70,7 +70,6 @@ type UseWorkbenchMapOptions = {
   onSelectFeature: (feature: DetailFeature) => void;
   selectedFeature: DetailFeature | null;
   simulationOverlay: FeatureCollection<Geometry> | null;
-  allowDemoSimulation: boolean;
   networkView?: NetworkViewParams | null;
   getAccessToken?: WorkbenchAccess;
   geoserverWorkspace?: string;
@@ -121,8 +120,6 @@ const SOURCE_GROUP_BY_ID: Record<string, string> = {
   ...Object.fromEntries(
     GEOSERVER_WATER_NETWORK_SOURCE_IDS.map((sourceId) => [sourceId, "geoserver-mvt"])
   ),
-  [SIMULATION_SOURCE_IDS.impactArea]: "annotation-source",
-  [SIMULATION_SOURCE_IDS.annotations]: "annotation-source",
   [SIMULATION_SOURCE_IDS.backendAnalysis]: "annotation-source"
 };
 
@@ -142,7 +139,6 @@ export function useWorkbenchMap({
   onSelectFeature,
   selectedFeature,
   simulationOverlay,
-  allowDemoSimulation,
   networkView,
   geoserverWorkspace,
   getAccessToken
@@ -150,11 +146,9 @@ export function useWorkbenchMap({
   const mapRef = useRef<MapLibreMap | null>(null);
   const impactVisibleRef = useRef(impactVisible);
   const simulationOverlayRef = useRef(simulationOverlay);
-  const allowDemoSimulationRef = useRef(allowDemoSimulation);
   const networkViewRef = useRef<NetworkViewParams>(networkView ?? WATER_NETWORK_GLOBAL_VIEW);
   const fittedNetworkViewRef = useRef<string | null>(null);
   simulationOverlayRef.current = simulationOverlay;
-  allowDemoSimulationRef.current = allowDemoSimulation;
   networkViewRef.current = networkView ?? WATER_NETWORK_GLOBAL_VIEW;
   const [mapReady, setMapReady] = useState(false);
   const [mapError, setMapError] = useState<string | null>(null);
@@ -315,10 +309,8 @@ export function useWorkbenchMap({
         const source = sources[sourceId];
         if (source) map.addSource(sourceId, source);
       });
-      map.addSource(SIMULATION_SOURCE_IDS.impactArea, simulationSources.impactArea);
-      map.addSource(SIMULATION_SOURCE_IDS.annotations, simulationSources.annotations);
       map.addSource(SIMULATION_SOURCE_IDS.backendAnalysis, simulationSources.backendAnalysis);
-      syncSimulationSourceData(map, simulationOverlayRef.current, allowDemoSimulationRef.current);
+      syncSimulationSourceData(map, simulationOverlayRef.current);
       await registerSupplyAssetImages(map, scadaAbortController.signal);
       if (scadaAbortController.signal.aborted) return;
       const scadaRegistration = await registerScadaImages(map, scadaAbortController.signal);
@@ -327,16 +319,13 @@ export function useWorkbenchMap({
         scadaRegistration.status === "unavailable"
           ? scadaFallbackBusinessLayers
           : scadaBusinessLayers;
-      simulationAnnotationLayers
-        .filter((layer) => layer.id === "simulation-impact-fill")
-        .forEach((layer) => map.addLayer(layer));
       filterWaterNetworkLayersBySourceIds(
         waterNetworkBusinessLayers,
         REQUIRED_GEOSERVER_SOURCE_IDS
       ).forEach((layer) => map.addLayer(layer));
       activeScadaBusinessLayers.forEach((layer) => map.addLayer(layer));
       simulationAnnotationLayers
-        .filter((layer) => layer.type !== "symbol" && layer.id !== "simulation-impact-fill")
+        .filter((layer) => layer.type !== "symbol")
         .forEach((layer) => map.addLayer(layer));
       filterWaterNetworkLayersBySourceIds(
         waterNetworkInteractionLayers,
@@ -484,8 +473,8 @@ export function useWorkbenchMap({
   useEffect(() => {
     const map = mapRef.current;
     if (!map || !mapReady) return;
-    syncSimulationSourceData(map, simulationOverlay, allowDemoSimulation);
-  }, [allowDemoSimulation, mapReady, simulationOverlay]);
+    syncSimulationSourceData(map, simulationOverlay);
+  }, [mapReady, simulationOverlay]);
 
   function fitToNetworkBounds() {
     const map = mapRef.current;
@@ -541,23 +530,12 @@ function getScadaStatusMessage(snapshot: Awaited<ReturnType<typeof fetchScadaSna
 
 function syncSimulationSourceData(
   map: MapLibreMap,
-  backendOverlay: FeatureCollection<Geometry> | null,
-  allowDemoSimulation: boolean
+  backendOverlay: FeatureCollection<Geometry> | null
 ) {
   const useBackendOverlay = Boolean(backendOverlay?.features.length);
   (map.getSource(SIMULATION_SOURCE_IDS.backendAnalysis) as GeoJSONSource | undefined)?.setData(
     useBackendOverlay ? backendOverlay! : EMPTY_SIMULATION_COLLECTION
   );
-  (map.getSource(SIMULATION_SOURCE_IDS.impactArea) as GeoJSONSource | undefined)?.setData(
-    useBackendOverlay || !allowDemoSimulation
-      ? EMPTY_SIMULATION_COLLECTION
-      : simulationSources.impactArea.data
-  );
-  (map.getSource(SIMULATION_SOURCE_IDS.annotations) as GeoJSONSource | undefined)?.setData(
-    useBackendOverlay || !allowDemoSimulation
-      ? EMPTY_SIMULATION_COLLECTION
-      : simulationSources.annotations.data
-  );
 }
 
 function syncDataDependentGeoServerLayers(