Lew Rossman
b0796f346a
Adding leakage model
2024-06-26 11:15:01 -04:00
Elad Salomons
cc9105fda6
Merge pull request #804 from OpenWaterAnalytics/bugfix/compiler-fix
...
fixes compilation with old compilers and keeps our programming conven…
2024-06-25 13:24:34 +03:00
Sam Hatchett
31cfd60943
fixes compilation with old compilers and keeps our programming conventions of declaring variables
2024-06-24 15:10:06 -04:00
Sam Hatchett
94d136b58f
Merge pull request #803 from OpenWaterAnalytics/bugfix/tank-never-drains
...
fixes regression related to tank fill/empty events
2024-06-24 15:07:33 -04:00
Sam Hatchett
0329819f04
fixes regression related to tank fill/empty events
...
In the affected code, q is really just a proxy for flow direction. And in cases where a tank has filled in a previous step, its connected link will have been TEMPCLOSED making the flow pretty small. When this occurs, the link actually never opens even if dH says that the tank should be draining.
2024-06-24 13:08:13 -04:00
Lew Rossman
59f7295739
Merge pull request #802 from YuChunTsao/add-INP-section-column-headings
...
feat: Add column headings for sections in INP file
2024-06-18 13:23:36 -04:00
Yu Chun Tsao
96cb4c9c88
fix: Use two semicolons in each heading line
2024-06-19 00:46:17 +08:00
Lew Rossman
d055157558
Merge pull request #801 from OpenWaterAnalytics/API_fixes
...
Fix two legacy API functions
2024-06-18 07:46:25 -04:00
Yu Chun Tsao
317990a8d1
feat: Add column headings for sections in INP file
...
This commit includes the following changes:
- Column headings have been added for each section in the INP file.
- The alignment of the values has been updated to match these headings.
These enhancements improve readability and understanding of the INP file.
2024-06-15 23:48:14 +08:00
Lew Rossman
6ac4156fd0
Update report.c
...
Change a "printf" statement to "sprintf".
2024-06-14 09:49:28 -04:00
Lew Rossman
62f0bc6db7
Fix two legacy API functions
2024-06-13 07:49:14 -04:00
Lew Rossman
109a93f7d5
Merge pull request #798 from zannads/dev-netadjlist_fix
...
Fix Issue 789- PR 791
2024-06-05 15:47:04 -04:00
Dennis
c79f125608
Fix: pass the network pointer to freeadjlists and not the project
2024-06-04 13:49:24 +02:00
Lew Rossman
c131c4cd1d
Merge pull request #786 from Vitens/dev
...
add ENgetnodesvalues and ENgetlinksvalues methods
2024-06-03 11:24:11 -04:00
Abel Heinsbroek
93a0b3671b
Merge branch 'dev' into dev
2024-05-31 21:36:57 +02:00
Lew Rossman
8b6be71956
Merge pull request #788 from OpenWaterAnalytics/dev-rename_emitter_backflow_keyword
...
Changes EMITTER BACKFLOW keyword
2024-05-29 08:25:19 -04:00
Lew Rossman
7b334875f8
Merge pull request #797 from lbutler/big-fix-emitter-coefficient
...
Fix emitter-related NaN errors from EN_setnodevalue API
2024-05-29 08:23:56 -04:00
Lew Rossman
375823851a
Merge pull request #791 from zannads/dev-netadjlist_fix
...
Fix Issue #789 - free network Adjlist
2024-05-29 08:22:48 -04:00
Lew Rossman
9958ef6d44
Merge pull request #792 from zannads/dev-npipes_fix
...
Fix Issue #790 - incorrect number of pipes
2024-05-29 08:15:43 -04:00
lbutler
48934c7089
Updated ReleaseNotes for EN_EMITTER bug
2024-05-28 22:23:46 -04:00
lbutler
a74171fa26
Fix emitter-related NaN errors by initializing zero EmitterFlow to 1.0.
...
Co-Authored-By: Lew Rossman <LRossman@outlook.com >
2024-05-28 22:18:29 -04:00
Dennis
d50c673321
Fix Issue #790 - incorrect number of pipes
...
The pipe counter was not decreased if the element was a pipe.
2024-05-23 10:33:30 +03:00
Dennis
9307913c5b
Proposed Fix for Issue #789
...
See the comment on the Issue.
2024-05-23 10:24:29 +03:00
Lew Rossman
7e66114863
Changes EMITTER BACKFLOW keyword
...
This change avoids a conflict between the EMITTER EXPONENT and EMITTER BACKFLOW keywords when running a v2.3 input file in the v2.2 EPANET GUI.
2024-05-11 12:37:52 -04:00
Abel Heinsbroek
9637f5c092
change names of new functions to ENgetnodevalues and ENgetlinkvalues
2024-04-24 15:20:59 +02:00
Abel Heinsbroek
4dff3bd054
add ENgetnodesvalues and ENgetlinksvalues methods
2024-04-23 11:31:17 +02:00
Elad Salomons
ef234a1919
Merge pull request #784 from Mariosmsk/patch-4
...
fix badge macos link.
Thank you @Mariosmsk!
2024-04-21 19:23:00 +03:00
Marios S. Kyriakou
c5232f47a7
fix badge macos link
2024-04-21 19:13:14 +03:00
Elad Salomons
72eeb3d4d8
Merge pull request #781 from eladsal/update-build-script
...
Update old build script
2024-04-21 13:02:12 +03:00
Elad Salomons
3d7cf9a522
Merge pull request #1 from Mariosmsk/retry-builds
...
Retry builds
2024-04-21 12:09:28 +03:00
Marios S. Kyriakou
cd242aa819
add retry build.
2024-04-21 11:48:57 +03:00
Marios S. Kyriakou
8bf2334708
add macos badge
2024-04-21 11:48:49 +03:00
Marios S. Kyriakou
ac09675f79
update cmake version
2024-04-21 11:48:43 +03:00
Sam Hatchett
c34ab39887
Merge pull request #779 from OpenWaterAnalytics/fix-conan-build
...
Fixes conan build, adds documentation for this option
2024-04-10 17:03:29 -04:00
Elad Salomons
e396bd8b58
Update old build script
...
Update old build script with validate.c file
2024-04-10 21:38:57 +03:00
Sam Hatchett
efe4e21846
fixes conan build, adds enums to cmake
2024-04-09 13:32:28 -04:00
Lew Rossman
7d360480d0
Merge pull request #777 from OpenWaterAnalytics/dev-tank_validation_fix
...
Update validate.c
2024-03-21 12:39:11 -04:00
Lew Rossman
c24f334208
Update validate.c
...
Fixes false negative when checking if a tank's min/max levels fall within its volume curve (see issue #767 ).
2024-03-19 14:38:47 -04:00
Lew Rossman
6b72b0a21c
Merge pull request #776 from Mariosmsk/add-workflow-for-macos-build
...
Create macos.yml workflow.
2024-03-19 14:30:10 -04:00
Lew Rossman
31395615d1
Merge pull request #775 from Mariosmsk/update-workflows-rm-warnings
...
Update workflows to use Node.js 20 due to deprecation of Node.js 16
2024-03-19 14:29:36 -04:00
Lew Rossman
19327c0a51
Merge pull request #774 from Mariosmsk/patch-2
...
Delete tests/outfile/data/enP1kAlM
2024-03-19 14:29:11 -04:00
Marios S. Kyriakou
630f9f09a9
Create macos.yml
2024-03-19 13:31:03 +02:00
Marios S. Kyriakou
1cf1b0803b
Update workflows to use Node.js 20 due to deprecation of Node.js 16
2024-03-19 13:18:11 +02:00
Marios S. Kyriakou
857aaf678b
Delete tests/outfile/data/enP1kAlM
...
Remove the unnecessary file.
2024-03-19 12:43:38 +02:00
Lew Rossman
2f4e4e5139
Merge pull request #771 from OpenWaterAnalytics/dev-tank_overflow_fix
...
Account for mass lost in tank overflow
2024-03-18 13:37:07 -04:00
Lew Rossman
029b441dd4
Merge pull request #759 from Mariosmsk/update-workflows
...
update workflows to include the header files in the artifact
2024-03-14 08:25:28 -04:00
Lew Rossman
6d6f244a5f
Merge pull request #766 from lbutler/update-readme-jan-2024
...
Update release notes and remove depreciated constants
2024-03-13 09:51:56 -04:00
Lew Rossman
482f658df4
Account for mass lost in tank overflow
...
This change addresses issue #769 .
2024-03-13 09:22:33 -04:00
Sam Hatchett
0c3d444eef
enhances build files with INSTALL options and fixes Conan
2024-02-12 11:47:35 -05:00
Lew Rossman
ade7027ddb
Merge pull request #768 from OpenWaterAnalytics/dev-tank_validation_bug_fix
...
Update validate.c
2024-01-25 12:34:20 -05:00
